[asterisk-dev] [Code Review] Create best practices documentation

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/507/#review1529
-----------------------------------------------------------


I think we should also mention IAX2 and XMPP/Jabber somewhere in the document, just to make it clear that it's not only SIP we're talking about.


/README-SERIOUSLY.bestpractices.txt
<https://reviewboard.asterisk.org/r/507/#comment3427>

    Both examples just ignore errors. I think we should also handle errors - show how to go about if the EXTEN and SAFE_EXTEN is not the same - and play "invalid" or something.



/README-SERIOUSLY.bestpractices.txt
<https://reviewboard.asterisk.org/r/507/#comment3428>

    Internet with capital i - twice in this paragraph.



/README-SERIOUSLY.bestpractices.txt
<https://reviewboard.asterisk.org/r/507/#comment3429>

    Hmm. Either two sentences or a comma after the URL.


- Olle E


On 2010-02-16 20:14:35, Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/507/
> -----------------------------------------------------------
> 
> (Updated 2010-02-16 20:14:35)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Olle E Johansson.
> 
> 
> Summary
> -------
> 
> This is a best practices document, which was spurned from the discussion on the asterisk-dev and asterisk-users list. It discusses how to utilize FILTER() in the dialplan to only accept characters that you expect to accept. There are also additional sections in the document that discusses proper device names, secure passwords, and reducing typing errors in dialplans.
> 
> It should be noted this document is not just about security issues, but rather is a document framework for all best practices information that may be deemed appropriate from the community, for the community.
> 
> 
> This addresses bugs 16808 and 16810.
>     https://issues.asterisk.org/view.php?id=16808
>     https://issues.asterisk.org/view.php?id=16810
> 
> 
> Diffs
> -----
> 
>   /README-SERIOUSLY.bestpractices.txt PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/507/diff
> 
> 
> Testing
> -------
> 
> Reviewed the document a few times, hoping to correct any grammatical errors, etc...
> 
> 
> Thanks,
> 
> Leif
> 
>