[asterisk-dev] [Code Review] Adds support to GROUP_MATCH_COUNT for regex matching on category
Russell Bryant
russell at digium.com
Tue Feb 16 20:13:49 CST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/503/#review1528
-----------------------------------------------------------
Ship it!
Nice work, Jeff!
- Russell
On 2010-02-16 11:01:48, Jeff Peeler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/503/
> -----------------------------------------------------------
>
> (Updated 2010-02-16 11:01:48)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Mostly what needs reviewing is the new unit test, although it is pretty simple.
>
>
> This addresses bug 16642.
> https://issues.asterisk.org/view.php?id=16642
>
>
> Diffs
> -----
>
> /trunk/main/app.c 246898
> /trunk/tests/test_app.c PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/503/diff
>
>
> Testing
> -------
>
> Unit test created and passes all tests. Perhaps could be expanded upon, but matching counts work as expected.
>
>
> Thanks,
>
> Jeff
>
>
More information about the asterisk-dev
mailing list