[asterisk-dev] [Code Review] Make all of the various rtpqos variables available to the dialplan

[Tilghman Lesher]

> On 2010-02-15 20:22:32, Russell Bryant wrote:
> > /trunk/channels/sip/include/dialog.h, lines 37-39
> > <https://reviewboard.asterisk.org/r/501/diff/2/?file=8120#file8120line37>
> >
> >     I don't think this is SIP dialog related.

I'm open to suggestions on where it should go.  I needed it to be accessible to my separate source file, which is why I added the definition in a header file, although it could certainly move eleswhere.


> On 2010-02-15 20:22:32, Russell Bryant wrote:
> > /trunk/channels/sip/include/sip_utils.h, lines 28-29
> > <https://reviewboard.asterisk.org/r/501/diff/2/?file=8122#file8122line28>
> >
> >     Hmm ... I'm not sure if bindaddr and sched belong here.  They're not really "random utilities".  Maybe sip.h?

Possibly, but David created that file with lots of structures, enums, etc. and no actual data declarations.  globals.h, perhaps?


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/501/#review1524
-----------------------------------------------------------


On 2010-02-15 13:10:28, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/501/
> -----------------------------------------------------------
> 
> (Updated 2010-02-15 13:10:28)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Trunk has several new RTPQOS variables documented in the CHANNEL dialplan function that up until now were not actually available.
> 
> 
> This addresses bug 16652.
>     https://issues.asterisk.org/view.php?id=16652
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/Makefile 245944 
>   /trunk/channels/chan_sip.c 245944 
>   /trunk/channels/sip/dialplan_functions.c PRE-CREATION 
>   /trunk/channels/sip/include/config_parser.h 245944 
>   /trunk/channels/sip/include/dialog.h PRE-CREATION 
>   /trunk/channels/sip/include/dialplan_functions.h PRE-CREATION 
>   /trunk/channels/sip/include/sip_utils.h 245944 
> 
> Diff: https://reviewboard.asterisk.org/r/501/diff
> 
> 
> Testing
> -------
> 
> Unit test written, tested.
> 
> 
> Thanks,
> 
> Tilghman
> 
>