[asterisk-dev] [Code Review] Adds support to GROUP_MATCH_COUNT for regex matching on category

Jeff Peeler jpeeler at digium.com
Mon Feb 15 13:57:25 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/503/
-----------------------------------------------------------

(Updated 2010-02-15 13:57:25.719155)


Review request for Asterisk Developers.


Changes
-------

Implemented changes as suggested by Russell.


Summary
-------

Mostly what needs reviewing is the new unit test, although it is pretty simple.


This addresses bug 16642.
    https://issues.asterisk.org/view.php?id=16642


Diffs (updated)
-----

  /trunk/main/app.c 246666 
  /trunk/tests/test_app.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/503/diff


Testing
-------

Unit test created and passes all tests. Perhaps could be expanded upon, but matching counts work as expected.


Thanks,

Jeff




More information about the asterisk-dev mailing list