[asterisk-dev] [Code Review] SIP: more code refactoring, more unit tests

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/499/
-----------------------------------------------------------

(Updated 2010-02-12 16:23:18.645164)


Review request for Asterisk Developers.


Changes
-------

This update adds some additional failure checks to the new unit tests.


Summary
-------

----- Code Refactoring Changes ----
- read_to_parts() moved to reqresp_parser.c and has been renamed as get_name_and_number()
- get_in_brackets() moved to reqresp_parser.c
- find_closing_quotes() added to sip_utils.h

----- Logic Changes -----
- get_name_and_number() now uses parse_uri() and get_calleridname() for parsing.  Before this change only names within quotes were found, when names not within quotes are possible.

----- New Unit Tests -----
sip_get_name_and_number_test
sip_get_in_brackets_test


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 246542 
  /trunk/channels/sip/include/reqresp_parser.h 246542 
  /trunk/channels/sip/include/sip_utils.h 246542 
  /trunk/channels/sip/reqresp_parser.c 246542 

Diff: https://reviewboard.asterisk.org/r/499/diff


Testing
-------

-tested sip redirect to verify get_name_and_number still works as expected.
-ran unit tests, verified they all passed.


Thanks,

David