[asterisk-dev] [Code Review] astobj2 unit test

Russell Bryant russell at digium.com
Thu Feb 11 12:16:56 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/496/#review1497
-----------------------------------------------------------

Ship it!


Nice work, David!

- Russell


On 2010-02-11 11:30:24, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/496/
> -----------------------------------------------------------
> 
> (Updated 2010-02-11 11:30:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a unit test for main/astobj2.c.  All the status update calls will be changed to match Russell's tweak once it is committed.  That is why I do not set the error string anywhere.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/astobj2.c 246298 
>   /trunk/tests/test_astobj2.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/496/diff
> 
> 
> Testing
> -------
> 
> ran unit test, verified it passes. 
> 
> 
> Thanks,
> 
> David
> 
>




More information about the asterisk-dev mailing list