[asterisk-dev] [Code Review] Add test_event.c, with a test for event creation

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/495/#review1490
-----------------------------------------------------------

Ship it!


I don't know much about the event api, so I can't comment on the code fix at this point.  The unit test looks ready to go except for the minor thing I pointed out.  I'm giving the unit test a ship it!


/trunk/tests/test_event.c
<https://reviewboard.asterisk.org/r/495/#comment3365>

    We have not been putting new lines in the description. I believe this will make the xml and txt output skip a line which will look weird.


- David


On 2010-02-08 19:33:03, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/495/
> -----------------------------------------------------------
> 
> (Updated 2010-02-08 19:33:03)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Review 493 is a prerequisite for this one.
> 
> This is a new test module for adding unit tests for the ast_event API.  A first test has been implemented which exercises code for creating events and getting data out of the events after they have been created.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/event.h 245666 
>   /trunk/main/event.c 245666 
>   /trunk/tests/test_event.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/495/diff
> 
> 
> Testing
> -------
> 
> I loaded the test and executed it.  It now passes.  One exciting bit is that the test originally failed due to a bug in the event API.  However, that has now been fixed in trunk and the test passes.
> 
> 
> Thanks,
> 
> Russell
> 
>