[asterisk-dev] [Code Review] Clear up Solaris issues with NULL documentation.
Russell Bryant
russell at digium.com
Tue Feb 9 17:37:02 CST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/497/#review1485
-----------------------------------------------------------
Ship it!
Nice work, Tilghman. Other than an unrelated change to the Makefile, this looks good to me.
/trunk/Makefile
<https://reviewboard.asterisk.org/r/497/#comment3346>
You've got an unrelated change here.
- Russell
On 2010-02-09 15:31:51, Tilghman Lesher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/497/
> -----------------------------------------------------------
>
> (Updated 2010-02-09 15:31:51)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Solaris has an issue with NULLs printed in a %s format string. Detect this behavior, and ensure that it doesn't cause issues with some unit tests.
>
>
> This addresses bug 16689.
> https://issues.asterisk.org/view.php?id=16689
>
>
> Diffs
> -----
>
> /trunk/Makefile 245728
> /trunk/configure UNKNOWN
> /trunk/configure.ac 245728
> /trunk/include/asterisk/autoconfig.h.in 245728
> /trunk/res/res_agi.c 245728
>
> Diff: https://reviewboard.asterisk.org/r/497/diff
>
>
> Testing
> -------
>
> Tested with and without XML defined, tested configure script, tested unit test output, all good.
>
>
> Thanks,
>
> Tilghman
>
>
More information about the asterisk-dev
mailing list