[asterisk-dev] [Code Review] Mute / Unmute manager commands for MixMonitor

[Julian Lyndon-Smith]

> On 2010-02-05 09:43:39, Sean Bright wrote:
> > trunk/apps/app_mixmonitor.c, line 655
> > <https://reviewboard.asterisk.org/r/487/diff/7/?file=8012#file8012line655>
> >
> >     Add a . after 'specified'

done


> On 2010-02-05 09:43:39, Sean Bright wrote:
> > trunk/apps/app_mixmonitor.c, line 664
> > <https://reviewboard.asterisk.org/r/487/diff/7/?file=8012#file8012line664>
> >
> >     Make sure to get rid of this trailing whitespace when you commit this.

done


> On 2010-02-05 09:43:39, Sean Bright wrote:
> > trunk/apps/app_mixmonitor.c, line 674
> > <https://reviewboard.asterisk.org/r/487/diff/7/?file=8012#file8012line674>
> >
> >     Pull this out of the block and get rid of the else, like this:
> >     
> >         if (ast_strlen_zero(name)) {
> >             /* ... */
> >         }
> >     
> >         c = ast_channel_get_by_name(name);

done


> On 2010-02-05 09:43:39, Sean Bright wrote:
> > trunk/include/asterisk/audiohook.h, lines 65-66
> > <https://reviewboard.asterisk.org/r/487/diff/7/?file=8013#file8013line65>
> >
> >     Comment these two lines in doxygen format to describe the purpose of these bits.

done


> On 2010-02-05 09:43:39, Sean Bright wrote:
> > trunk/include/asterisk/audiohook.h, line 282
> > <https://reviewboard.asterisk.org/r/487/diff/7/?file=8013#file8013line282>
> >
> >     Needs doxygen documentation

done


- Julian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/487/#review1467
-----------------------------------------------------------


On 2010-02-06 08:20:29, Julian Lyndon-Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/487/
> -----------------------------------------------------------
> 
> (Updated 2010-02-06 08:20:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> For PCI-DSS compliance we are not allowed to record a credit card number in a MixMonitor file. However, we must record all conversations ....
> 
> I have added a new feature to audiohooks so that you can mute either read / write or both types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself.
> 
> MixMonitor now has two manager commands
> 
> 1) manager show command MuteMixMonitor
> Action: MuteMixMonitor
> Synopsis: Mute a channel in MixMonitor
> Privilege: <none>
> Description: Mutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to mute.
>   Direction: Which part to mute. read|write|both (from channel|to channel|both channels).
> 
> 2) manager show command unMuteMixMonitor
> Action: unMuteMixMonitor
> Synopsis: unMute a channel in MixMonitor
> Privilege: <none>
> Description: unMutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to unmute.
>   Direction: Which part to unmute. read|write|both (from channel|to channel|both channels).
> 
> 
> This addresses bug 16740.
>     https://issues.asterisk.org/view.php?id=16740
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_mixmonitor.c 244767 
>   trunk/include/asterisk/audiohook.h 244767 
>   trunk/main/audiohook.c 244767 
> 
> Diff: https://reviewboard.asterisk.org/r/487/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4 : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> Tested on trunk : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> 
> 
> Thanks,
> 
> Julian
> 
>