[asterisk-dev] [Code Review] Mute / Unmute manager commands for MixMonitor

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/487/#review1472
-----------------------------------------------------------



trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/487/#comment3324>

    Should this be AMI_FAILURE or something?  There are a number of failure cases returning success.
    
    Also, I know this wasn't added by your patch, but since it's new, I wanted to comment on the naming of the return value constants.  I think that they should be AST_AMI_SUCCESS, etc., to match our current naming convention of always using an AST_ prefix.



trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/487/#comment3325>

    You're leaking a channel reference.



trunk/include/asterisk/audiohook.h
<https://reviewboard.asterisk.org/r/487/#comment3326>

    Use:
    
    \retval 0 success
    \retval -1 failure



trunk/main/audiohook.c
<https://reviewboard.asterisk.org/r/487/#comment3327>

    It's probably worth checking that the frame's datalen is non-zero before doing this.


- Russell


On 2010-02-06 08:20:29, Julian Lyndon-Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/487/
> -----------------------------------------------------------
> 
> (Updated 2010-02-06 08:20:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> For PCI-DSS compliance we are not allowed to record a credit card number in a MixMonitor file. However, we must record all conversations ....
> 
> I have added a new feature to audiohooks so that you can mute either read / write or both types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself.
> 
> MixMonitor now has two manager commands
> 
> 1) manager show command MuteMixMonitor
> Action: MuteMixMonitor
> Synopsis: Mute a channel in MixMonitor
> Privilege: <none>
> Description: Mutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to mute.
>   Direction: Which part to mute. read|write|both (from channel|to channel|both channels).
> 
> 2) manager show command unMuteMixMonitor
> Action: unMuteMixMonitor
> Synopsis: unMute a channel in MixMonitor
> Privilege: <none>
> Description: unMutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to unmute.
>   Direction: Which part to unmute. read|write|both (from channel|to channel|both channels).
> 
> 
> This addresses bug 16740.
>     https://issues.asterisk.org/view.php?id=16740
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_mixmonitor.c 244767 
>   trunk/include/asterisk/audiohook.h 244767 
>   trunk/main/audiohook.c 244767 
> 
> Diff: https://reviewboard.asterisk.org/r/487/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4 : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> Tested on trunk : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> 
> 
> Thanks,
> 
> Julian
> 
>