[asterisk-dev] chan_sip: configurable peer username indigestauthentication

[Olle E. Johansson]

5 feb 2010 kl. 13.32 skrev Nick Lewis:

>> Nick: Have you really tested this patch or are you talking based on
> just reading the source?
> 
>> From reading the source I confirmed that when challengeuser is not
> specified in sip.conf its functionality is equivalent to existing code
> so I think it is safe to implement without causing regression. (I am not
> commenting on whether the patch successfully adds the required
> functionality or whether there are any adverse consequences of
> specifying challengeuser in sip.conf)

uYou where saying that we could safely integrate this, without testing. I think you have to be a bit more careful about changes in chan_sip. After years of working with that code and supporting it for customers and in the bug tracker, I'm a bit more careful than that. I want to test and think before I support integration of that patch, even though I like the idea and the new function it implements.

/O