[asterisk-dev] [Code Review] Mute / Unmute manager commands for MixMonitor

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/487/#review1463
-----------------------------------------------------------


Just a few things that I noticed.


trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/487/#comment3301>

    "... Must be read, write, or both."



trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/487/#comment3303>

    The RESULT_* definitions are for CLI command handlers, not manager actions.  This should just be 'return 0.'  In fact, all of the return statements in this function should just return 0, regardless of success vs. failure.
    



trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/487/#comment3300>

    "... Must be read, write, or both."



trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/487/#comment3302>

    Since you return from the 'if' block, you don't need this part to be inside an 'else'.



trunk/include/asterisk/audiohook.h
<https://reviewboard.asterisk.org/r/487/#comment3304>

    Since you're using bits here, you don't need to reserve one for 'both' you can just use:
    
        AST_AUDIOHOOK_MUTE_READ | AST_AUDIOHOOK_MUTE_WRITE


- Sean


On 2010-02-03 17:10:09, Julian Lyndon-Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/487/
> -----------------------------------------------------------
> 
> (Updated 2010-02-03 17:10:09)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> For PCI-DSS compliance we are not allowed to record a credit card number in a MixMonitor file. However, we must record all conversations ....
> 
> I have added a new feature to audiohooks so that you can mute either read / write or both types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself.
> 
> MixMonitor now has two manager commands
> 
> 1) manager show command MuteMixMonitor
> Action: MuteMixMonitor
> Synopsis: Mute a channel in MixMonitor
> Privilege: <none>
> Description: Mutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to mute.
>   Direction: Which part to mute. read|write|both (from channel|to channel|both channels).
> 
> 2) manager show command unMuteMixMonitor
> Action: unMuteMixMonitor
> Synopsis: unMute a channel in MixMonitor
> Privilege: <none>
> Description: unMutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to unmute.
>   Direction: Which part to unmute. read|write|both (from channel|to channel|both channels).
> 
> 
> This addresses bug 16740.
>     https://issues.asterisk.org/view.php?id=16740
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/audiohook.h 244498 
>   trunk/main/audiohook.c 244498 
>   trunk/apps/app_mixmonitor.c 244498 
> 
> Diff: https://reviewboard.asterisk.org/r/487/diff
> 
> 
> Testing
> -------
> 
> Tested on a 1.4 version (only difference I think is that frame->data in 1.4 becomes frame->data.ptr in trunk in audiohook.c
> 
> Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> 
> 
> Thanks,
> 
> Julian
> 
>