[asterisk-dev] [Code Review] Mute / Unmute manager commands for MixMonitor

[Julian Lyndon-Smith]

> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/apps/app_mixmonitor.c, line 649
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7985#file7985line649>
> >
> >     Missing space between 'm,"A'

fixed


> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/apps/app_mixmonitor.c, line 700
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7985#file7985line700>
> >
> >     Same spacing comment between variables

fixed


> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/apps/app_mixmonitor.c, line 706
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7985#file7985line706>
> >
> >     CODING-GUIDELINES, requires spaces between values aka '(30, 10)' etc

fixed


> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/apps/app_mixmonitor.c, line 709
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7985#file7985line709>
> >
> >     From memory this no longer needs to be here now that you have XML doc

removed


> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/apps/app_mixmonitor.c, line 733
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7985#file7985line733>
> >
> >     should do same as the code above 'res |='

fixed


> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/main/audiohook.c, line 136
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7987#file7987line136>
> >
> >     Declarations should be all at the top, move these to under 'muteme'

fixed


> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/main/audiohook.c, line 1047
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7987#file7987line1047>
> >
> >     missing braces, extra blank lines

fixed


> On 2010-02-03 07:04:47, Brad Latus wrote:
> > trunk/main/audiohook.c, line 1053
> > <https://reviewboard.asterisk.org/r/487/diff/2/?file=7987#file7987line1053>
> >
> >     excess line

fixed


- Julian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/487/#review1454
-----------------------------------------------------------


On 2010-02-03 04:24:25, Julian Lyndon-Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/487/
> -----------------------------------------------------------
> 
> (Updated 2010-02-03 04:24:25)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> For PCI-DSS compliance we are not allowed to record a credit card number in a MixMonitor file. However, we must record all conversations ....
> 
> I have added a new feature to audiohooks so that you can mute either read / write or both types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself.
> 
> MixMonitor now has two manager commands
> 
> 1) manager show command MuteMixMonitor
> Action: MuteMixMonitor
> Synopsis: Mute a channel in MixMonitor
> Privilege: <none>
> Description: Mutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to mute.
>   Direction: Which part to mute. read|write|both (from channel|to channel|both channels).
> 
> 2) manager show command unMuteMixMonitor
> Action: unMuteMixMonitor
> Synopsis: unMute a channel in MixMonitor
> Privilege: <none>
> Description: unMutes a Mixmonitor Channel.
> Variables:
>   Channel: Channel to unmute.
>   Direction: Which part to unmute. read|write|both (from channel|to channel|both channels).
> 
> 
> This addresses bug 16740.
>     https://issues.asterisk.org/view.php?id=16740
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_mixmonitor.c 244498 
>   trunk/include/asterisk/audiohook.h 244498 
>   trunk/main/audiohook.c 244498 
> 
> Diff: https://reviewboard.asterisk.org/r/487/diff
> 
> 
> Testing
> -------
> 
> Tested on a 1.4 version (only difference I think is that frame->data in 1.4 becomes frame->data.ptr in trunk in audiohook.c
> 
> Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
> 
> 
> Thanks,
> 
> Julian
> 
>