[asterisk-dev] [Code Review] app_directory, support option 'p(n)' as documented with CLI online help, branches 1.6.1 to trunk.

[Alec Davis]

> On 2010-02-02 11:32:22, Tilghman Lesher wrote:
> > trunk/apps/app_directory.c, line 670
> > <https://reviewboard.asterisk.org/r/481/diff/2/?file=7932#file7932line670>
> >
> >     Why pass the option arguments array all the way down to where it's used?  Why not convert the integer at the top level and pass that down instead?
> 
> Alec Davis wrote:
>     1. Following style of other apps, app-dial:wait_for_answer.
>     2. Should additional option args need to be evaluated at a later stage, the structure is inplace to simply evaluate them, no future need to add additional parameters to each level of calling.
>     
>     A change I should make, is to change the pointer name to opt_args instead of opts.
>

After relooking at changing opts to opt_args, leave it as is.

Ready to commit to trunk, branch 1.6.1 version of patch is up at mantis bug 16751.   


- Alec


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/481/#review1438
-----------------------------------------------------------


On 2010-02-02 03:25:03, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/481/
> -----------------------------------------------------------
> 
> (Updated 2010-02-02 03:25:03)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> finish off preliminary work done for initial pause before presenting directory name to caller.
> 
> Currently, 'core show application DIRECTORY' from 1.6.1 through to trunk indicates the 'p(n)' option is available, where in fact there is no code to act on it, other than to populate opts[OPT_ARG_PAUSE].
> 
> 
> This addresses bug 16751.
>     https://issues.asterisk.org/view.php?id=16751
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_directory.c 244325 
> 
> Diff: https://reviewboard.asterisk.org/r/481/diff
> 
> 
> Testing
> -------
> 
> 1.6.1 production server.
> 'p' on it own doesn't introduce delay, as expected.
> 'p(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names individually.
> 'mp(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names as a list.
> 'p(6000)' enforces a maximum of a 3 second delay.
> 
> 
> Thanks,
> 
> Alec
> 
>