[asterisk-dev] [Code Review] High Resolution Call Time for Billsec and Duration

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/461/#review1444
-----------------------------------------------------------



/trunk/Makefile
<https://reviewboard.asterisk.org/r/461/#comment3256>

    Did you really intend for this diff to be here?



/trunk/apps/app_parkandannounce.c
<https://reviewboard.asterisk.org/r/461/#comment3257>

    This looks like an extraneous change, too.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/461/#comment3258>

    More extraneous changes



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/461/#comment3259>

    and again



/trunk/main/file.c
<https://reviewboard.asterisk.org/r/461/#comment3260>

    and again



/trunk/main/xmldoc.c
<https://reviewboard.asterisk.org/r/461/#comment3261>

    I'm going to stop now, and ask you to post another diff, this time with only the changes that were meant to be here.


- Tilghman


On 2010-02-02 01:42:56, Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/461/
> -----------------------------------------------------------
> 
> (Updated 2010-02-02 01:42:56)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This allows for the showing of the accurate times for billable time and call duration.
> Adds new flag to CDR function 'f' for the above fields.
> 
> This came about by bug #16559 and I thought i'd take a go at making it happen.
> 
> We can drop a few of the modules for ones we want to depreciate like sql-lite / odbc (in favour of sql-lite3 / adaptive_odbc)
> 
> 
> This addresses bug 16559.
>     https://issues.asterisk.org/view.php?id=16559
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 244040 
>   /trunk/Makefile 244040 
>   /trunk/UPGRADE.txt 244040 
>   /trunk/addons/cdr_mysql.c 244040 
>   /trunk/apps/app_parkandannounce.c 244040 
>   /trunk/cdr/cdr_adaptive_odbc.c 244040 
>   /trunk/cdr/cdr_odbc.c 244040 
>   /trunk/cdr/cdr_pgsql.c 244040 
>   /trunk/cdr/cdr_sqlite.c 244040 
>   /trunk/cdr/cdr_tds.c 244040 
>   /trunk/configs/cdr_custom.conf.sample 244040 
>   /trunk/configs/cdr_odbc.conf.sample 244040 
>   /trunk/configs/cdr_sqlite3_custom.conf.sample 244040 
>   /trunk/configs/cdr_syslog.conf.sample 244040 
>   /trunk/configs/cdr_tds.conf.sample 244040 
>   /trunk/funcs/func_cdr.c 244040 
>   /trunk/main/channel.c 244040 
>   /trunk/main/features.c 244040 
>   /trunk/main/file.c 244040 
>   /trunk/main/tdd.c 244040 
>   /trunk/main/xmldoc.c 244040 
>   /trunk/res/res_rtp_asterisk.c 244040 
> 
> Diff: https://reviewboard.asterisk.org/r/461/diff
> 
> 
> Testing
> -------
> 
> Compile test only.
> 
> Basic test with cdr_custom
> 
> 
> Thanks,
> 
> Brad
> 
>