[asterisk-dev] [Code Review] Add touch_on_change to menuselect

[Russell Bryant]

> On 2010-02-02 12:53:42, Russell Bryant wrote:
> > /trunk/menuselect.c, line 1198
> > <https://reviewboard.asterisk.org/r/482/diff/1/?file=7942#file7942line1198>
> >
> >     Shouldn't there be some bounds checking here so that silly input can't crash menuselect?

Ah, I see that your code is the same as the surrounding code that does almost the same thing.  So, meh for now ...


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/482/#review1441
-----------------------------------------------------------


On 2010-02-02 12:47:23, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/482/
> -----------------------------------------------------------
> 
> (Updated 2010-02-02 12:47:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The recent addition of the TEST_FRAMEWORK define unfortunately rebuilds everything when you turn it on, instead of only the modules which depend upon TEST_FRAMEWORK.  However, every module that uses TEST_FRAMEWORK also includes test.h.  If we simply touch that file, then every source that depends upon test.h will be rebuilt.  This should improve the needed time to recompile a branch.
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect.h 695 
>   /trunk/menuselect.c 695 
> 
> Diff: https://reviewboard.asterisk.org/r/482/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>