[asterisk-dev] [Code Review] app_directory, support option 'p(n)' as documented with CLI online help, branches 1.6.1 to trunk.

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/481/#review1438
-----------------------------------------------------------



trunk/apps/app_directory.c
<https://reviewboard.asterisk.org/r/481/#comment3247>

    Why pass the option arguments array all the way down to where it's used?  Why not convert the integer at the top level and pass that down instead?


- Tilghman


On 2010-02-02 03:25:03, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/481/
> -----------------------------------------------------------
> 
> (Updated 2010-02-02 03:25:03)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> finish off preliminary work done for initial pause before presenting directory name to caller.
> 
> Currently, 'core show application DIRECTORY' from 1.6.1 through to trunk indicates the 'p(n)' option is available, where in fact there is no code to act on it, other than to populate opts[OPT_ARG_PAUSE].
> 
> 
> This addresses bug 16751.
>     https://issues.asterisk.org/view.php?id=16751
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_directory.c 244325 
> 
> Diff: https://reviewboard.asterisk.org/r/481/diff
> 
> 
> Testing
> -------
> 
> 1.6.1 production server.
> 'p' on it own doesn't introduce delay, as expected.
> 'p(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names individually.
> 'mp(1000)' introduces 1 second delay after intial 3 letters are entered, then presents names as a list.
> 'p(6000)' enforces a maximum of a 3 second delay.
> 
> 
> Thanks,
> 
> Alec
> 
>