[asterisk-dev] tilghman: branch 1.6.0 r244072 - in /branches/1.6.0: ./ channels/ main/

[Tilghman Lesher]

On Monday 01 February 2010 16:15:32 Russell Bryant wrote:
> On 02/01/2010 02:02 PM, Tilghman Lesher wrote:
> > Well, yes, it will, but the error wasn't entirely removed, either.  Atis
> > remarked on this and suggested yet another exception to the rule.  This
> > tends to suggest that with so many exceptions, the previous approach
> > wasn't the right way to do this.  With the patch above, the error may
> > still occur, but it will only occur once in a brief while, not
> > constantly, once the limit has been reached.
>
> What was the additional exception proposed to be added?  For reference,
> this is what we previously had this in chan_local:
>
> if (other->pbx || other->_bridge || !ast_strlen_zero(other->appl)) {
>          ast_queue_frame(other, f);
> }
>
> --
> Russell Bryant
> Digium, Inc. | Engineering Manager, Open Source Software
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> www.digium.com -=- www.asterisk.org -=- blogs.asterisk.org

Apparently, it wasn't posted to the issue, but here's a brief discussion:

[19:14:04] <atis_home> Corydon76-dig: btw, i'm still seeing "Exceptionally 
long voice queue" on Local channels with your patches to chan_local :p
[19:14:10] <atis_home> should i open new issue?
...
[08:30:23] <atis_work> Corydon76-dig: do you remember 
ast_strlen_zero(other->appl) and ast_queue_frame
[08:30:25] <atis_work> in chan_local
[08:30:33] <atis_work> fixing "Exceptionally long voice queue"
[08:30:40] <Corydon76-dig> Yes
[08:31:06] <atis_work> so, there's one more situation when other->appl is 
zero, but control frames need to be forwarded
[08:31:29] <atis_work> if Originating Local/123/n and Context/Exten/Priority
[08:31:53] <Corydon76-dig> M16525
[08:31:55] <MuffinMan> [ready for testing] [Asterisk] Applications/app_chanspy 
0016525: [patch] Cannot spy on channel when a local channel is involved 
reported by kobaz https://issues.asterisk.org/view.php?id=16525
[08:32:03] <Corydon76-dig> Try that patch there
[08:32:55] <atis_work> Ah, that's completely different approach 
to "Exceptionally long voice queue"
[08:33:09] <atis_work> i tested with adding check for control frames and 
forwarding them, that would work
[08:33:47] <Corydon76-dig> I'd rather kill too-old frames than add yet another 
exception
[08:33:55] <atis_work> sure
[08:34:36] <Corydon76-dig> It just seems like we keep piling on the 
exceptions, and it's therefore clear that that wasn't the right approach
[08:36:48]  Signoff: beres (Quit: bye)
[08:39:37] <atis_work> Corydon76-dig: thanks it works
[08:39:50] <atis_work> I added comments to all related issues
 

-- 
Tilghman Lesher
Digium, Inc. | Senior Software Developer
twitter: Corydon76 | IRC: Corydon76-dig (Freenode)
Check us out at: www.digium.com & www.asterisk.org