[asterisk-dev] [Code Review] High Resolution Call Time for Billsec and Duration

Brad Latus snuffy22 at gmail.com
Mon Feb 1 01:46:12 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/461/
-----------------------------------------------------------

(Updated 2010-02-01 01:46:11.927752)


Review request for Asterisk Developers.


Changes
-------

Fixed the missing braces, also fixed case insensitive matching for func_cdr (didn't look hard enough @ main/cdr.c to notice it was strcasecmp())

Compiles, works with cdr_custom


Summary
-------

This allows for the showing of the accurate times for billable time and call duration.
Adds new flag to CDR function 'f' for the above fields.

This came about by bug #16559 and I thought i'd take a go at making it happen.

We can drop a few of the modules for ones we want to depreciate like sql-lite / odbc (in favour of sql-lite3 / adaptive_odbc)


This addresses bug 16559.
    https://issues.asterisk.org/view.php?id=16559


Diffs (updated)
-----

  /trunk/CHANGES 244040 
  /trunk/UPGRADE.txt 244040 
  /trunk/addons/cdr_mysql.c 244040 
  /trunk/cdr/cdr_adaptive_odbc.c 244040 
  /trunk/cdr/cdr_odbc.c 244040 
  /trunk/cdr/cdr_pgsql.c 244040 
  /trunk/cdr/cdr_sqlite.c 244040 
  /trunk/cdr/cdr_tds.c 244040 
  /trunk/configs/cdr_custom.conf.sample 244040 
  /trunk/configs/cdr_odbc.conf.sample 244040 
  /trunk/configs/cdr_sqlite3_custom.conf.sample 244040 
  /trunk/configs/cdr_syslog.conf.sample 244040 
  /trunk/configs/cdr_tds.conf.sample 244040 
  /trunk/funcs/func_cdr.c 244040 

Diff: https://reviewboard.asterisk.org/r/461/diff


Testing
-------

Compile test only.


Thanks,

Brad




More information about the asterisk-dev mailing list