[asterisk-dev] [Code Review] Properly route responses according to the Via headers in the request

Matthew Nicholson reviewboard at asterisk.org
Wed Dec 22 17:37:05 UTC 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-12-22 11:37:05.175099)

Review request for Asterisk Developers.


Updated patch based on comments on the review and on the mailing list and review of section 18.2 of RFC 3261.


This patch makes asterisk respect the Via headers in a request when responding to it. This is necessary in the even that a stateless proxy is in between asterisk and the requester. Without this patch, the response is simply routed back to the address we received the initial request from (unless nat=yes is set).

Diffs (updated)

  /branches/1.4/channels/chan_sip.c 299447 

Diff: https://reviewboard.asterisk.org/r/1059/diff


Briefly tested using openser as a stateless proxy and another asterisk machine as the requester.  I sent and invite, then some INFO DTMF messages.  Without the patch, our asterisk machine sends all responses to the INFO requests to the proxy, with the patch they are properly routed to the requesting asterisk machine.  I also briefly tested with openser configured to use the Record-Route header as a stateful proxy.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101222/eafd2d52/attachment-0001.htm>

More information about the asterisk-dev mailing list