[asterisk-dev] [Code Review] Properly route responses according to the Via headers in the request

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1059/
-----------------------------------------------------------

(Updated 2010-12-16 14:36:19.488564)


Review request for Asterisk Developers.


Changes
-------

Updated to address schmidts comments.  Also updated to respect Record-Route headers.


Summary
-------

This patch makes asterisk respect the Via headers in a request when responding to it. This is necessary in the even that a stateless proxy is in between asterisk and the requester. Without this patch, the response is simply routed back to the address we received the initial request from (unless nat=yes is set).


Diffs (updated)
-----

  /branches/1.4/channels/chan_sip.c 294163 

Diff: https://reviewboard.asterisk.org/r/1059/diff


Testing
-------

Briefly tested using openser as a stateless proxy and another asterisk machine as the requester.  I sent and invite, then some INFO DTMF messages.  Without the patch, our asterisk machine sends all responses to the INFO requests to the proxy, with the patch they are properly routed to the requesting asterisk machine.  I also briefly tested with openser configured to use the Record-Route header as a stateful proxy.


Thanks,

Matthew

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101216/2f9298bd/attachment.htm>