[asterisk-dev] [Code Review] Properly route responses according to the Via headers in the request

[Matthew Nicholson]

> On 2010-12-16 13:41:05, schmidts wrote:
> > i dont know the rfc part of via headers itself, but i think its a good way at all.
> > 
> > what happens if there is a record route and a via header in one sip message? I dont know if this could happens but IMHO record route overrules a via.
> >

Hmm, it looks like asterisk does not respect the Record-Route header on responses either. I will consult the RFC to see if Via or Record-Route takes precedence.


> On 2010-12-16 13:41:05, schmidts wrote:
> > /branches/1.4/channels/chan_sip.c, line 5007
> > <https://reviewboard.asterisk.org/r/1059/diff/1/?file=14663#file14663line5007>
> >
> >     via could not be zero here cause you allready check this 5 rows aboth without changing via in between.

Noted.


> On 2010-12-16 13:41:05, schmidts wrote:
> > /branches/1.4/channels/chan_sip.c, line 6662
> > <https://reviewboard.asterisk.org/r/1059/diff/1/?file=14663#file14663line6662>
> >
> >     Maybe it would be better to check the response of get_header before. its not necessary to call this function on every sip message if there is no via header. 
> >     ast_strdupa in function calls could cause some strange issues. there was something about this some weeks ago.

I remember something with that as well, but I don't remember exactly what it was.  I'm not sure why there would be no Via header though.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1059/#review3036
-----------------------------------------------------------


On 2010-12-16 11:39:59, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1059/
> -----------------------------------------------------------
> 
> (Updated 2010-12-16 11:39:59)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch makes asterisk respect the Via headers in a request when responding to it. This is necessary in the even that a stateless proxy is in between asterisk and the requester. Without this patch, the response is simply routed back to the address we received the initial request from (unless nat=yes is set).
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_sip.c 294163 
> 
> Diff: https://reviewboard.asterisk.org/r/1059/diff
> 
> 
> Testing
> -------
> 
> Briefly tested using openser as a stateless proxy and another asterisk machine as the requester.  I sent and invite, then some INFO DTMF messages.  Without the patch, our asterisk machine sends all responses to the INFO requests to the proxy, with the patch they are properly routed to the requesting asterisk machine.  I also briefly tested with openser configured to use the Record-Route header as a stateful proxy.
> 
> 
> Thanks,
> 
> Matthew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101216/5e672130/attachment-0001.htm>