[asterisk-dev] [Code Review] Issue 18243: Update initial state of hints when new device state provider registers
Russell Bryant
reviewboard at asterisk.org
Sat Dec 11 20:54:55 UTC 2010
> On 2010-12-11 06:43:31, Russell Bryant wrote:
> >
Here is another thought. If this changes the state of a hint, should hint watchers be notified? I think that would be expected, but I do not think it is done.
- Russell
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1048/#review3023
-----------------------------------------------------------
On 2010-12-04 06:59:52, Olle E Johansson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1048/
> -----------------------------------------------------------
>
> (Updated 2010-12-04 06:59:52)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> When the dialplan loads, all hints are initialized to a first state. If a device state provider is not loaded at the time, like meetme (or the new device state provider in chan_sip/Pinana), the hints are not initialized to the initial state. This affects all hints that have an initial state, like a registration in chan_sip, which is a state for "presence" subscriptions using SIMPLE in chan_sip.
>
> The patch in /svn/asterisk/team/oej/pinana-initialize-devstate-1.4 fixes this by re-initializing all hints using the new device state provider after registration of a new device state provider.
>
>
> This addresses bug 18243.
> https://issues.asterisk.org/view.php?id=18243
>
>
> Diffs
> -----
>
> /team/oej/pinana-initialize-devstate-1.4/include/asterisk/pbx.h 297578
> /team/oej/pinana-initialize-devstate-1.4/main/devicestate.c 297578
> /team/oej/pinana-initialize-devstate-1.4/main/pbx.c 297578
>
> Diff: https://reviewboard.asterisk.org/r/1048/diff
>
>
> Testing
> -------
>
> Testing done while testing Pinana, which adds a new device state provider for remote sip states. Without this patch, the device state provider hints would never initialize properly when ASterisk starts, since the dialplan loads before chan_sip.
>
>
> Thanks,
>
> Olle E
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101211/85e1dacd/attachment.htm
More information about the asterisk-dev
mailing list