[asterisk-dev] [Code Review] Provide better inline backtraces

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1055/#review3017
-----------------------------------------------------------



/branches/1.4/main/logger.c
<https://reviewboard.asterisk.org/r/1055/#comment6236>

    These references to i should be to stackfr instead. This causes a compilation error.


- Mark


On 2010-12-09 15:06:59, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1055/
> -----------------------------------------------------------
> 
> (Updated 2010-12-09 15:06:59)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Presently, we rely upon backtrace_symbols(3) within glibc to provide the symbols when doing an ast_backtrace().  There is better information already available within our binary.  If we use gdb, we're able to access this information.  The main benefit is being able to see local symbols in each file, instead of only global API handles.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/apps/app_sayunixtime.c 297774 
>   /branches/1.4/build_tools/menuselect-deps.in 297774 
>   /branches/1.4/configure UNKNOWN 
>   /branches/1.4/configure.ac 297774 
>   /branches/1.4/include/asterisk/autoconfig.h.in 297774 
>   /branches/1.4/include/asterisk/utils.h 297774 
>   /branches/1.4/main/Makefile 297774 
>   /branches/1.4/main/logger.c 297774 
>   /branches/1.4/main/utils.c 297774 
>   /branches/1.4/makeopts.in 297774 
> 
> Diff: https://reviewboard.asterisk.org/r/1055/diff
> 
> 
> Testing
> -------
> 
> Now provides excellent information, including file, line, and function name.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101209/7853f4e5/attachment-0001.htm