[asterisk-dev] [Code Review] Parse mwi => lines in sip.conf properly to avoid segfaults and have it work.

[Marquis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1053/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Modify the parsing of mwi subscription lines in sip.conf in order to avoid an existing segfault and to have it properly populate the struct for subscriptions.


This addresses bug 18350.
    https://issues.asterisk.org/view.php?id=18350


Diffs
-----

  /branches/1.8/channels/chan_sip.c 297775 
  /branches/1.8/configs/sip.conf.sample 297775 

Diff: https://reviewboard.asterisk.org/r/1053/diff


Testing
-------

Added lines for various possible permutations (kept in the diff for documentation) as well as temporary (not in the diff) debug lines to verify all strings were set to their expected values.  Reporter in issue 18350 also applied patch and verified that his segfault was gone and that subscriptions were working.


Thanks,

Marquis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101209/4af2e658/attachment.htm