[asterisk-dev] [Code Review] Add generic testsuite code for running SIPp based tests

[Paul Belanger]

> On 2010-12-03 11:17:26, David Vossel wrote:
> > /asterisk/trunk/lib/python/asterisk/sipp.py, line 46
> > <https://reviewboard.asterisk.org/r/1046/diff/1/?file=14249#file14249line46>
> >
> >     maybe document that configs are supposed to be in the /configs/ast1/ directory of the supplied base test directory.  I'm guessing you called it ast1 so it would be possible to expand this to do multiple asterisk instances in the future or something?
> >     
> >

That is my issue, I documented it in the changelog but not README.txt. Will update it shortly.


> On 2010-12-03 11:17:26, David Vossel wrote:
> > /asterisk/trunk/lib/python/asterisk/sipp.py, lines 51-52
> > <https://reviewboard.asterisk.org/r/1046/diff/1/?file=14249#file14249line51>
> >
> >     It might be good to make timeout configurable.  There are many instances where retransmission timers are being tested that will be longer than 20s.  Other times it may be a problem if it takes longer than a second.  This should be configurable.

Same could be said about the IP address, a configurable options to change it.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1046/#review2998
-----------------------------------------------------------


On 2010-12-03 11:07:40, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1046/
> -----------------------------------------------------------
> 
> (Updated 2010-12-03 11:07:40)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> I wrote two tests yesterday based on SIPp scenarios and the code was nearly identical.  This led me to write a SIPpTest class that made the logic reusable for any test based on SIPp scenario files.  
> 
> To demonstrate how it is used, I added a new test, sip/options, which tests Asterisk's response to an OPTIONS request.  It sends an OPTIONS request for 2 different extensions and verifies that the response is what we expect for each one (200 or 404).
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/sipp.py PRE-CREATION 
>   /asterisk/trunk/tests/sip/options/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/sip/options/run-test PRE-CREATION 
>   /asterisk/trunk/tests/sip/options/sipp/options.xml PRE-CREATION 
>   /asterisk/trunk/tests/sip/options/sipp/options2.xml PRE-CREATION 
>   /asterisk/trunk/tests/sip/options/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/sip/tests.yaml 1048 
>   /asterisk/trunk/tests/tests.yaml 1048 
> 
> Diff: https://reviewboard.asterisk.org/r/1046/diff
> 
> 
> Testing
> -------
> 
> I ran the test and it passes.
> 
> 
> Thanks,
> 
> Russell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101203/82a54aa5/attachment.htm