[asterisk-dev] [Code Review] Resolve compile error under FreeBSD

[Paul Belanger]

> On 2010-12-02 06:36:30, Russell Bryant wrote:
> >
> 
> Russell Bryant wrote:
>     Actually, this should probably check to see if march is already in CFLAGS before adding it ourselves like this.

You are right, I'm seeing '-march=i386 -march=i686' when I enable NOISY_BUILDS=yes.  However, I'm having trouble locating the logic that adds '-march=i386'.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1043/#review2989
-----------------------------------------------------------


On 2010-12-01 21:54:05, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1043/
> -----------------------------------------------------------
> 
> (Updated 2010-12-01 21:54:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Below you can see Asterisk 1.4 fails to compile, a result of not using -march=i686.  This patch will default to _ASTCFLAGS+=-march=i686, still allowing ASTCFLAGS to override the setting.
> 
> ---
> 
>    [LD] abstract_jb.o acl.o aescrypt.o aeskey.o aestab.o alaw.o app.o ast_expr2.o ast_expr2f.o asterisk.o astfd.o astmm.o astobj2.o audiohook.o autoservice.o callerid.o cdr.o channel.o chanvars.o cli.o config.o cryptostub.o db.o devicestate.o dial.o dns.o dnsmgr.o dsp.o enum.o file.o fixedjitterbuf.o frame.o fskmodem.o global_datastores.o http.o image.o indications.o io.o jitterbuf.o loader.o logger.o manager.o md5.o netsock.o pbx.o plc.o poll.o privacy.o rtp.o say.o sched.o sha1.o slinfactory.o srv.o stdtime/localtime.o strcompat.o tdd.o term.o test.o threadstorage.o translate.o udptl.o ulaw.o utils.o editline/libedit.a db1-ast/libdb1.a  -> asterisk
> utils.o(.text+0x65): In function `ast_atomic_fetchadd_int':
> /usr/home/digium/digium/asterisk/testing/1.4/include/asterisk/lock.h:1314: undefined reference to `__sync_fetch_and_add_4'
> utils.o(.text+0x7f): In function `ast_atomic_dec_and_test':
> /usr/home/digium/digium/asterisk/testing/1.4/include/asterisk/lock.h:1360: undefined reference to `__sync_sub_and_fetch_4'
> gmake[1]: *** [asterisk] Error 1
> gmake: *** [main] Error 2
> *** Error code 2
> 
> 
> Diffs
> -----
> 
>   branches/1.4/Makefile 297183 
> 
> Diff: https://reviewboard.asterisk.org/r/1043/diff
> 
> 
> Testing
> -------
> 
> Asterisk now compile under FreeBSD 8.1
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101202/a792b8af/attachment.htm