[asterisk-dev] [Code Review] Initialize the adaptive jitter buffer's offset to the timestamp of the first frame

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1041/#review2988
-----------------------------------------------------------

Ship it!


- Russell


On 2010-12-01 17:46:32, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1041/
> -----------------------------------------------------------
> 
> (Updated 2010-12-01 17:46:32)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When the adaptive jitter buffer is enabled in sip.conf, the first frame placed in the jitter buffer fails with something like:
> 
> jb_warning_output: Resyncing the jb. last_delay 0, this delay -215886466, threshold 1000, new offset 215886466
> 
> This happens because the offset is not initialized before calling jb_put(). This patch modifies jb_put_first_adaptive() to set the offset to the frame's timestamp.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/abstract_jb.c 297175 
> 
> Diff: https://reviewboard.asterisk.org/r/1041/diff
> 
> 
> Testing
> -------
> 
> sip.conf jbenabled=yes, jbimpl=adaptive, jbforced=yes, jbresyncthreshold=1000. Phone1 -> Asterisk -> Phone2. Before patch: warning, After patch: no warning. 
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101202/b6df00be/attachment-0001.htm