[asterisk-dev] [asterisk-security] [Code Review] 1.4 manager configuration reset to default values before config files are reloaded

[Russell Bryant]

On Tue, 2010-08-31 at 21:59 +0200, Olle E. Johansson wrote:
> For some reason reviewboard gave me server errors tonight...

What error?

> Please check chan_sip.c where we use #define DEFAULT_UPPER_CASE instead of declaring static variables.

I do agree that the variables should be decalred in ALL_CAPS.  However,
I would prefer that there were "static const" instead of "#define".
It's more type-safe, respects scope, and is a more explicit way of
specifying that there should only be one instance of this constant
stored, not one for every place the preprocessor replaced SOME_CONSTANT
with a value.

-- 
Russell Bryant
Digium, Inc.  |  Engineering Manager, Open Source Software
445 Jan Davis Drive NW   -    Huntsville, AL 35806  -  USA
jabber: rbryant at digium.com    -=-    skype: russell-bryant
www.digium.com -=- www.asterisk.org -=- blogs.asterisk.org