[asterisk-dev] [Code Review] 1.4 manager configuration reset to default values before config files are reloaded

Russell Bryant russell at digium.com
Tue Aug 31 13:52:35 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/883/#review2649
-----------------------------------------------------------



/branches/1.4/main/manager.c
<https://reviewboard.asterisk.org/r/883/#comment5774>

    Make the names of the defaults all caps, just by convention for constants.
    
    Also, convert the comments to doxygen format.  /*!< ... */


- Russell


On 2010-08-31 13:49:36, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/883/
> -----------------------------------------------------------
> 
> (Updated 2010-08-31 13:49:36)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Fixes a 1.4 (trunk and 1.4.36-rc1) bug where certain configuration options weren't being reset to their defaults when the manager.conf configuration was reloaded.
> 
> 
> This addresses bug 17917.
>     https://issues.asterisk.org/view.php?id=17917
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/manager.c 284314 
> 
> Diff: https://reviewboard.asterisk.org/r/883/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brett
> 
>




More information about the asterisk-dev mailing list