[asterisk-dev] [Code Review] pbx_spool unable to load call files in 1.8.0-beta4 and trunk

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/882/#review2645
-----------------------------------------------------------



/tags/1.8.0-beta4/pbx/pbx_spool.c
<https://reviewboard.asterisk.org/r/882/#comment5773>

    I can't think of any better ideas for fixing it, but I do wonder if there is any other place the sleep could be implemented.  It looks like this would enforce a half second between processing every call file.  This will be problematic in cases where people generate a _lot_ of calls using call files.
    
    Are the notifications put into a queue?  Perhaps there is a way to ensure that we only process events once they have been in the queue for some period of time (half a second) ?


- Russell


On 2010-08-30 14:45:53, Brett Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/882/
> -----------------------------------------------------------
> 
> (Updated 2010-08-30 14:45:53)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> With inotify, pbx_spool was reading files submitted to the spool before the operating system had a chance to finish writing the file. A sleep time of half a second was added between getting notified of a spool file and attempting to open it to fix this issue.
> 
> From mantis issue 17924
> ----------------------------------------
> While testing with 1.8beta, I always get the following errors, when I try to use a call file:
> 
> Aug 28 14:29:28 alix local0.warn asterisk[18174]: WARNING[18213]: pbx_spool.c:250 in apply_outgoing: At least one of app or extension must be specified, along with tech and dest in file /var/spool/asterisk/outgoing/sample.call
> 
> Aug 28 14:29:28 alix local0.warn asterisk[18174]: WARNING[18213]: pbx_spool.c:407 in scan_service: Invalid file contents in /var/spool/asterisk/outgoing/sample.call, deleting 
> 
> 
> This addresses bug 17924.
>     https://issues.asterisk.org/view.php?id=17924
> 
> 
> Diffs
> -----
> 
>   /tags/1.8.0-beta4/pbx/pbx_spool.c 284277 
> 
> Diff: https://reviewboard.asterisk.org/r/882/diff
> 
> 
> Testing
> -------
> 
> Tested on trunk-r284277, and 1.8.0-beta4.
> 
> 
> Thanks,
> 
> Brett
> 
>