[asterisk-dev] [Code Review] SIP: authenticate OPTIONS requests just like we would an INVITE

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/881/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

OPTIONS requests should be treated the same as an INVITE... which includes authentication.  This patch adds the ability for incoming out of dialog OPTION requests to be authenticated before providing a response indicating whether an extension is available or not.  The authentication routine works the exact same way as it does for incoming INVITEs.  This means that if a peer has 'insecure=invite' in their peer definition, the same will be true for the processing of the OPTIONS request.


Diffs
-----

  /trunk/channels/chan_sip.c 283769 

Diff: https://reviewboard.asterisk.org/r/881/diff


Testing
-------

I have tested this through a variety of sipp scenarios in attempt to verify that the OPTIONS request is treated the exact same as an INVITE request in regards to authentication.  I also tested this patch with Asterisk back to back verifying that qualify=yes still works as expected.  Asterisk's implementation to qualify peers as reachable using OPTIONS request does not care if it gets a"401" or a "200" response.


Thanks,

David