[asterisk-dev] [Code Review] Top down test "callparking" GSOC 2010

[mnick at digium.com]

> On 2010-08-18 10:11:59, Erin Spiceland wrote:
> > /asterisk/team/mnick/gsoc2010/trunk/tests/callparking/run-test, lines 105-109
> > <https://reviewboard.asterisk.org/r/848/diff/3/?file=12275#file12275line105>
> >
> >     Is this necessary? Anywhere it is called, you should be able to use "return agi.finish()."
> 
> Erin Spiceland wrote:
>     Rather, anywhere this function is returned by another function.

good suggestion Erin. I changed the code and commited it to trunk.
Thanks Erin, thanks Russell !


- mnick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/848/#review2619
-----------------------------------------------------------


On 2010-08-16 14:22:30, mnick wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/848/
> -----------------------------------------------------------
> 
> (Updated 2010-08-16 14:22:30)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a "callparking" top down test for asterisk:
>     
> 1.  userA calls userB
> 2.  userB dials # -> 700, to park userA (701).
> 3.  userB calls userC
> 4.  userC dials # -> 700, to park userB (702).
> 5.  userC dials 701 and retrieves userA
> 6.  userC dials 702 and retrieves userB
> - Test successful - 
> 
> the logger.conf(s) will be removed when I commit the test to the testsuite!
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mnick/gsoc2010/trunk/tests/callparking/run-test 720 
> 
> Diff: https://reviewboard.asterisk.org/r/848/diff
> 
> 
> Testing
> -------
> 
> Tested on 1.4, 1.6.0, 1.6.2 and trunk
> 
> 
> Thanks,
> 
> mnick
> 
>