[asterisk-dev] [Code Review] remove current STUN support from chan_sip.c

[Russell Bryant]

> On 2010-08-13 16:29:46, Russell Bryant wrote:
> >

There is probably a mention of STUN support in the CHANGES file.  It should probably be removed from there, too.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/855/#review2604
-----------------------------------------------------------


On 2010-08-11 13:16:37, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/855/
> -----------------------------------------------------------
> 
> (Updated 2010-08-11 13:16:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch removes the current broken/useless stun support from chan_sip.  This will take place in both 1.8 and Trunk.
> 
> Originally I had planned to correct the current use of STUN in chan_sip to work more reliably, but after a lengthy dev-list discussion it became apparent that the usage of STUN in chan_sip is not RFC compliant and has no real use case.  Hopefully removing this will make way for a correct implementation in the future.
> 
> I will update the CHANGES and UPDATE files for 1.8 and Trunk before committing this.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 281761 
>   /trunk/configs/sip.conf.sample 281761 
> 
> Diff: https://reviewboard.asterisk.org/r/855/diff
> 
> 
> Testing
> -------
> 
> compiled, ran Asterisk, and did some basic sanity checks.
> 
> 
> Thanks,
> 
> David
> 
>