[asterisk-dev] [Code Review] Check to make sure we can successfully link libsrtp in a shared library

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/857/#review2592
-----------------------------------------------------------

Ship it!


Nice work... this should address the problem well.

- Kevin


On 2010-08-11 17:30:16, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/857/
> -----------------------------------------------------------
> 
> (Updated 2010-08-11 17:30:16)
> 
> 
> Review request for Asterisk Developers and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> libsrtp ships in many distros without being compiled with the -fPIC flag for 64-bit machines. The upstream Makefile/configure scripts don't ever add the -fPIC option and only ship the static library. I have notified upstream, but even if they fix it we need to check for the problem in older versions. This patch attempts to detect problems linking libsrtp in a shared library.
> 
> 
> Diffs
> -----
> 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 281765 
> 
> Diff: https://reviewboard.asterisk.org/r/857/diff
> 
> 
> Testing
> -------
> 
> Tested on 64-bit with and without -fPIC compiled libsrtp.
> 
> 
> Thanks,
> 
> Terry
> 
>