[asterisk-dev] [Code Review] Add "core reload" CLI command

Russell Bryant russell at digium.com
Thu Aug 12 14:16:04 CDT 2010



> On 2010-08-12 14:15:12, Sean Bright wrote:
> > /branches/1.8/main/cli.c, line 305
> > <https://reviewboard.asterisk.org/r/859/diff/1/?file=12240#file12240line305>
> >
> >     I vote for handle_core_reload() instead of handle_reload2().

That works for me.  Consider it changed before commit.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/859/#review2588
-----------------------------------------------------------


On 2010-08-12 11:50:57, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/859/
> -----------------------------------------------------------
> 
> (Updated 2010-08-12 11:50:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> One of the CLI command changes that I have never been fully pleased with is "reload" -> "module reload".  My main gripe is that it seems bizarre to me to have to type "module reload" when I want to do a full reload.  So, I propose that we add a "core reload" command that is just for doing a global reload of the system.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/cli.c 281981 
> 
> Diff: https://reviewboard.asterisk.org/r/859/diff
> 
> 
> Testing
> -------
> 
> compiled, ran, executed "core reload"
> 
> 
> Thanks,
> 
> Russell
> 
>




More information about the asterisk-dev mailing list