[asterisk-dev] [Code Review] support for GNU/kFreeBSD

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/858/#review2580
-----------------------------------------------------------

Ship it!


- Russell


On 2010-08-11 19:44:17, Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/858/
> -----------------------------------------------------------
> 
> (Updated 2010-08-11 19:44:17)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> kFreeBSD is GNU (with glibc) on to of a FreeBSD kernel. See
> http://glibc-bsd.alioth.debian.org/porting/PORTING
> 
> This patch gets Asterisk close to building on Debian kFreeBSD i386,
> mainly by adding an extra test for __GLIBC__ in one or two (or more)
> places.
> 
> Also note that the OSARCH value may need extra tweaks.
> 
> TODO: there are too many cases where we check for a long list of BSDs. Isn't there a simpler way?
> And is it possible to check for specific features?
> 
> DAHDI support (and support for chan_vpb) was not tested.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_oss.c 281910 
>   /trunk/main/Makefile 281910 
>   /trunk/main/acl.c 281910 
>   /trunk/main/netsock.c 281910 
>   /trunk/utils/muted.c 281910 
> 
> Diff: https://reviewboard.asterisk.org/r/858/diff
> 
> 
> Testing
> -------
> 
> Building on kFreeBSD and Linux.
> 
> 
> Thanks,
> 
> Tzafrir
> 
>