[asterisk-dev] [Code Review] res_stun_monitor module

[David Vossel]

> On 2010-08-11 13:44:19, Russell Bryant wrote:
> > /trunk/res/res_stun_monitor.c, lines 101-110
> > <https://reviewboard.asterisk.org/r/854/diff/2/?file=12184#file12184line101>
> >
> >     Use if/else and then you can get rid of the goto.

I used the goto here even though we could just fall through with an if/else to be consistent with my error handling.


> On 2010-08-11 13:44:19, Russell Bryant wrote:
> > /trunk/res/res_stun_monitor.c, line 180
> > <https://reviewboard.asterisk.org/r/854/diff/2/?file=12184#file12184line180>
> >
> >     remove thsi line

why?


> On 2010-08-11 13:44:19, Russell Bryant wrote:
> > /trunk/res/res_stun_monitor.c, lines 190-193
> > <https://reviewboard.asterisk.org/r/854/diff/2/?file=12184#file12184line190>
> >
> >     I think this is a no-op.  On startup, it's never going to treat the file as unchanged.

but it will if you unload then reload the module.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/854/#review2567
-----------------------------------------------------------


On 2010-08-11 11:46:41, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/854/
> -----------------------------------------------------------
> 
> (Updated 2010-08-11 11:46:41)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The res_stun_monitor module monitors the perceived external ip/port provided by a STUN server and sends out an event when that perceived ip/port changes in any way.  This patch adds chan_sip and chan_iax as listeners to this event.  Both of these channel drivers react to the event by regenerating all outbound registers in order to alert the endpoints being registered with to the new address location.  This feature's primary use case is when Asterisk is behind a NAT in which the external ip address is dynamic or the port mappings of the NAT device are subject to change.
> 
> I will update the CHANGES file before committing this.  That is not included within this review though.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_iax2.c 281758 
>   /trunk/channels/chan_sip.c 281758 
>   /trunk/configs/iax.conf.sample 281758 
>   /trunk/configs/res_stun_monitor.conf.sample PRE-CREATION 
>   /trunk/configs/sip.conf.sample 281758 
>   /trunk/include/asterisk/event_defs.h 281758 
>   /trunk/res/res_stun_monitor.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/854/diff
> 
> 
> Testing
> -------
> 
> I tested all the res_stun_monitor.conf options to verify functionality.
> I tested the channel driver's event listening by triggering an address change and verifying registrations are sent via wireshark.
> 
> 
> Thanks,
> 
> David
> 
>