[asterisk-dev] [Code Review] [branch] Expand select(2) bits to allow for more than FD_SETSIZE file descriptors

[Kevin Fleming]

> On 2010-08-11 13:14:10, Russell Bryant wrote:
> > /branches/1.4/channels/chan_alsa.c, lines 284-307
> > <https://reviewboard.asterisk.org/r/824/diff/3/?file=12158#file12158line284>
> >
> >     Does the revents field need to be reset on each iteration of this loop?

Yes it does. poll() does not initialize the revents fields of the array itself.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/824/#review2556
-----------------------------------------------------------


On 2010-08-11 09:54:11, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/824/
> -----------------------------------------------------------
> 
> (Updated 2010-08-11 09:54:11)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Presently, when the number of file descriptors expands beyond FD_SETSIZE descriptors, we have troubles when those file descriptors are used with select(2).  Usually, this causes memory corruption, because the bitfields are not large enough, and parts of memory beyond the bitfield are corrupted.  This change both expands the default bitfield, as well as adding checks to ensure that memory beyond the end of bitfields are not corrupted.
> 
> 
> This addresses bug 17678.
>     https://issues.asterisk.org/view.php?id=17678
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_alsa.c 281720 
>   /branches/1.4/channels/chan_misdn.c 281720 
>   /branches/1.4/channels/chan_oss.c 281720 
>   /branches/1.4/channels/chan_phone.c 281720 
>   /branches/1.4/configure UNKNOWN 
>   /branches/1.4/configure.ac 281720 
>   /branches/1.4/include/asterisk/autoconfig.h.in 281720 
>   /branches/1.4/include/asterisk/channel.h 281720 
>   /branches/1.4/include/asterisk/poll-compat.h 281720 
>   /branches/1.4/include/asterisk/select.h PRE-CREATION 
>   /branches/1.4/main/asterisk.c 281720 
>   /branches/1.4/main/poll.c 281720 
>   /branches/1.4/res/res_features.c 281720 
> 
> Diff: https://reviewboard.asterisk.org/r/824/diff
> 
> 
> Testing
> -------
> 
> Architectural review only.  Testing to commence, when other developers agree with the architecture of these changes.
> 
> 
> Thanks,
> 
> Tilghman
> 
>