[asterisk-dev] [asterisk-commits] dvossel: trunk r278619 - /trunk/channels/chan_sip.c

[Klaus Darilion]

Hi!

Is it really necessary that a broken client fills up logfiles with 
stupid warnings?

IMO this is not worth a warning, DEBUG level would be fine.

regards
Klaus

Am 22.07.2010 16:56, schrieb SVN commits to the Asterisk project:
> Author: dvossel
> Date: Thu Jul 22 09:56:26 2010
> New Revision: 278619
>
> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=278619
> Log:
> update sip subscription debug message to a warning message
>
> If the Expire header of a SUBSCRIBE is less that our expiremin,
> a log warning will be displayed.
>
> Modified:
>      trunk/channels/chan_sip.c
>
> Modified: trunk/channels/chan_sip.c
> URL: http://svnview.digium.com/svn/asterisk/trunk/channels/chan_sip.c?view=diff&rev=278619&r1=278618&r2=278619
> ==============================================================================
> --- trunk/channels/chan_sip.c (original)
> +++ trunk/channels/chan_sip.c Thu Jul 22 09:56:26 2010
> @@ -23160,9 +23160,11 @@
>   		if (p->expiry>  max_expiry) {
>   			p->expiry = max_expiry;
>   		} else if (p->expiry<  min_expiry&&  p->expiry>  0) {
> +			transmit_response_with_minexpires(p, "423 Interval too small", req);
> +			ast_log(LOG_WARNING, "Received subscription for extension \"%s\" context \"%s\" "
> +				"with Expire header less that 'minexpire' limit. Received \"Expire: %d\" min is %d\n",
> +				p->exten, p->context, p->expiry, min_expiry);
>   			p->expiry = min_expiry;
> -			transmit_response_with_minexpires(p, "423 Interval too small", req);
> -			ast_debug(2, "Received SIP subscribe with Expire header less that our minexpires limit.\n");
>   			pvt_set_needdestroy(p, "Expires is less that the min expires allowed. ");
>   			return 0;
>   		}
>
>