[asterisk-dev] [Code Review] Prevent caller ID set on channel from getting discarded when originate used with local channel (small patch - review quickly, earn rewards!)

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/847/#review2538
-----------------------------------------------------------


Its a trap!

- David


On 2010-08-04 15:20:02, Jeff Peeler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/847/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 15:20:02)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The scenario here is that the channel that caller ID is set on is getting swapped with the zombie channel which is hung up and then lost. I am weary of the this change though as I am unsure if the clone channel would ever have valuable caller ID that needs to be swapped.
> 
> 
> This addresses bug 17138.
>     https://issues.asterisk.org/view.php?id=17138
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/main/channel.c 280912 
> 
> Diff: https://reviewboard.asterisk.org/r/847/diff
> 
> 
> Testing
> -------
> 
> Fixes the problematic scenario.
> 
> 
> Thanks,
> 
> Jeff
> 
>