[asterisk-dev] [Code Review] Handle all possible responses to REFER requests.

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/837/#review2537
-----------------------------------------------------------

Ship it!


Great work, This looks right to me. 

One concern though.  Breaking out of handle_response() to handle_response_refer() when the Method == SIP_REFER means all the processing on the response codes will be done in handle_response_refer() for REFER Requests...  There is some generic handling of response codes in handle_response() that is not handled in the handle_response_refer() function.  The only thing that really caught my eye was the 502-504 Server Error codes that queue up a CONGESTION frame on the channel.  That behavior for a REFER response might have been wrong to begin with, or may not even be possible.  I just thought it was worth noting.

- David


On 2010-08-04 08:11:42, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/837/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 08:11:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently asterisk does not handle certain responses to refer requests (e.g. 400).  This patch updates chan_sip to handle all possible responses to REFER requests.  Prior to this patch, asterisk can freeze in the Transfer app if asterisk receives an unhanded response to a REFER request.
> 
> 
> This addresses bug 17486.
>     https://issues.asterisk.org/view.php?id=17486
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 280743 
> 
> Diff: https://reviewboard.asterisk.org/r/837/diff
> 
> 
> Testing
> -------
> 
> The reporter tested the patch.
> 
> 
> Thanks,
> 
> Matthew
> 
>