[asterisk-dev] [Code Review] Handle all possible responses to REFER requests.

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/837/#review2527
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/837/#comment5552>

    s/failrues/failures... and maybe put this statement all on one line since it isn't that long.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/837/#comment5553>

    Why are we taking the handling of the sip SUBSCRIBE response here?


- David


On 2010-08-03 15:06:16, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/837/
> -----------------------------------------------------------
> 
> (Updated 2010-08-03 15:06:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently asterisk does not handle certain responses to refer requests (e.g. 400).  This patch updates chan_sip to handle all possible responses to REFER requests.  Prior to this patch, asterisk can freeze in the Transfer app if asterisk receives an unhanded response to a REFER request.
> 
> 
> This addresses bug 17486.
>     https://issues.asterisk.org/view.php?id=17486
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 280743 
> 
> Diff: https://reviewboard.asterisk.org/r/837/diff
> 
> 
> Testing
> -------
> 
> The reporter tested the patch.
> 
> 
> Thanks,
> 
> Matthew
> 
>