[asterisk-dev] [Code Review] External test for fastagi.execute()

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/835/#review2518
-----------------------------------------------------------



/asterisk/trunk/tests/fastagi/execute/run-test
<https://reviewboard.asterisk.org/r/835/#comment5545>

    This test looks good.  I would suggest a 4th test case, which is a variation on #3.  Try setting a normal variable, like:
    
    Set(MYDEBUG=foo)
    
    This will test different code than:
    
    Set(GLOBAL(debug)=bar)
    
    as the GLOBAL() case is writing to a dialplan function, while MYDEBUG is a normal channel variable.


- Russell


On 2010-08-03 09:24:40, Erin Spiceland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/835/
> -----------------------------------------------------------
> 
> (Updated 2010-08-03 09:24:40)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> External test for fastagi.execute() which works by executing three different commands not available through other fastagi functions.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/fastagi/execute/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fastagi/execute/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/835/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin
> 
>