[asterisk-dev] [Code Review] Testsuite: new install_configs() function and ability for backwards compatible configs

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/831/#review2516
-----------------------------------------------------------

Ship it!


This looks good for merging.

Are the config file changes needed, or were they just for testing?  If it was for testing, don't forget to pull that part out before merging.

- Russell


On 2010-08-01 07:16:26, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/831/
> -----------------------------------------------------------
> 
> (Updated 2010-08-01 07:16:26)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the ability to specify a config directory to be installed.  Everything within the directory, except the .svn, branch-1.4, branch-1.6.2 and branch-1.8 directories, will be copied over.
> 
> Also includes in functionality for backwards compatible config files.  If a sub-directory is found to be the same as the running instance, it will use that version of .config file.
> 
> IE:
> configs/sip.conf
> configs/branch-1.4/sip.conf
> 
> 
> ---
> Installs all files located in the configuration directory for this instance of Asterisk.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/sip_attended_transfer/configs/branch-1.4/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/iax-call-basic/run-test 627 
>   asterisk/trunk/tests/sip_attended_transfer/configs/sip.conf 627 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 627 
> 
> Diff: https://reviewboard.asterisk.org/r/831/diff
> 
> 
> Testing
> -------
> 
> Updated iax-call-basic to use the new function, and test passed as expected.
> 
> 
> Thanks,
> 
> pabelanger
> 
>