[asterisk-dev] [Code Review] Testsuite: new install_configs() function and ability for backwards compatible configs

[paul.belanger at polybeacon.com]

> On 2010-07-31 23:33:32, Russell Bryant wrote:
> > asterisk/trunk/lib/python/asterisk/asterisk.py, lines 138-141
> > <https://reviewboard.asterisk.org/r/831/diff/4/?file=12034#file12034line138>
> >
> >     Add a blank line before the new function.

done


> On 2010-07-31 23:33:32, Russell Bryant wrote:
> > asterisk/trunk/tests/iax-call-basic/run-test, line 43
> > <https://reviewboard.asterisk.org/r/831/diff/4/?file=12035#file12035line43>
> >
> >     shouldn't these changes be to the install_configs() function?

Yes, good eye.  My mistake with merging code.  Fixed.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/831/#review2513
-----------------------------------------------------------


On 2010-07-31 22:57:59, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/831/
> -----------------------------------------------------------
> 
> (Updated 2010-07-31 22:57:59)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add the ability to specify a config directory to be installed.  Everything within the directory, except the .svn, branch-1.4, branch-1.6.2 and branch-1.8 directories, will be copied over.
> 
> Also includes in functionality for backwards compatible config files.  If a sub-directory is found to be the same as the running instance, it will use that version of .config file.
> 
> IE:
> configs/sip.conf
> configs/branch-1.4/sip.conf
> 
> 
> ---
> Installs all files located in the configuration directory for this instance of Asterisk.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 627 
>   asterisk/trunk/tests/iax-call-basic/run-test 627 
>   asterisk/trunk/tests/sip_attended_transfer/configs/branch-1.4/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/sip_attended_transfer/configs/sip.conf 627 
> 
> Diff: https://reviewboard.asterisk.org/r/831/diff
> 
> 
> Testing
> -------
> 
> Updated iax-call-basic to use the new function, and test passed as expected.
> 
> 
> Thanks,
> 
> pabelanger
> 
>