[asterisk-dev] [Code Review] Parsing of reg->username containing @domain

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/628/#review1939
-----------------------------------------------------------



trunk/channels/sip/config_parser.c
<https://reviewboard.asterisk.org/r/628/#comment4171>

    Isn't reorder really only used as a temporary char * later on?  If so it probably doesn't belong in the args list at all.



trunk/channels/sip/config_parser.c
<https://reviewboard.asterisk.org/r/628/#comment4172>

    I'd just use a temporary char * here to handle the reordering.
    
    Perhaps add a comment as to why this is necessary as well.



trunk/main/app.c
<https://reviewboard.asterisk.org/r/628/#comment4173>

    I don't understand why this is necessary.  I thought the args array was initialized during declaration.


- David


On 2010-04-29 05:33:57, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/628/
> -----------------------------------------------------------
> 
> (Updated 2010-04-29 05:33:57)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> reg->username is parsed for each registration refresh rather than once on sip reload. A previously committed change that addressed this was reverted because it did not cater for registration strings that contained a peer name in the host field. This change does. 
> 
> 
> This addresses bug 14331.
>     https://issues.asterisk.org/view.php?id=14331
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 258227 
>   trunk/channels/sip/config_parser.c 258227 
>   trunk/channels/sip/include/sip.h 258228 
>   trunk/main/app.c 258227 
> 
> Diff: https://reviewboard.asterisk.org/r/628/diff
> 
> 
> Testing
> -------
> 
> Passes a new unit test for parsing usernames containing domains. Passes existing unit tests. Passes peername functional test with sip.conf snippet
> 
> [general]
> register=nick at quirk
> [quirk]
> fromdomain=10.10.235.48
> 
> 
> Thanks,
> 
> Nick
> 
>