[asterisk-dev] [Code Review] New manager actions for xmldoc

[Olle E. Johansson]

28 apr 2010 kl. 23.32 skrev Russell Bryant:

>  I'm not a huge fan of this part of the patch.
> 
>    It breaks API and ABI.  While it is trunk, we should always avoid both types of change when possible.
> 
>    I don't understand the purpose of registering a manager event.  It seems to be overloading the register API call for actions, which is for registering callbacks.  If a register API call events really is needed, then I'd rather see it as a separate API call, instead of overloading this one and causing the API disruption in the tree.
> 
>    Instead of requiring registration of each event, why not just open the XML doc and traverse it for ami_events?

I do agree. This is only a documentation effort that should not really touch code or API/ABI.

It is an important project as Events are poorly documented if at all.

/O