[asterisk-dev] [Code Review] CLI command 'manager show settings'

Russell Bryant russell at digium.com
Wed Apr 28 16:38:19 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/630/#review1924
-----------------------------------------------------------

Ship it!


looks good to me

- Russell


On 2010-04-28 10:55:22, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/630/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 10:55:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds 'manager show settings' CLI command.  Most of the logic was used from chan_sip.c.
> 
> 
> This addresses bug 16343.
>     https://issues.asterisk.org/view.php?id=16343
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 259663 
>   /trunk/include/asterisk/cli.h 259663 
>   /trunk/include/asterisk/manager.h 259663 
>   /trunk/main/manager.c 259663 
> 
> Diff: https://reviewboard.asterisk.org/r/630/diff
> 
> 
> Testing
> -------
> 
> Local developers and testing boxes.
> 
> 
> Thanks,
> 
> pabelanger
> 
>




More information about the asterisk-dev mailing list