[asterisk-dev] [Code Review] MixMonitor external test

David Vossel dvossel at digium.com
Wed Apr 28 16:08:33 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/632/
-----------------------------------------------------------

(Updated 2010-04-28 16:08:33.339415)


Review request for Asterisk Developers.


Changes
-------

addresses comments.  Getting the version number isn't necessary now since it does not affect logic, but I left the code in the test that parses that option.  I plan to expand this test in the future, and the version may necessary then.


Summary
-------

MixMonitor external test.

Tests MixMonitor with StopMixMonitor, verifying that StopMixMonitor releases the audio file so it can be processed by the dialplan.
Tests MixMonitor without StopMixMonitor, verifying that MixMonitor stops correctly on hangup.
Tests the size of the two audio files to see if they are what we expect given the length of time processed.

Future improvements to this test will include using AUDIOHOOK_INHERIT.


Diffs (updated)
-----

  /asterisk/trunk/tests/mixmonitor/configs/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/mixmonitor/run-test PRE-CREATION 
  /asterisk/trunk/tests/mixmonitor/test-config.yaml PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/632/diff


Testing
-------

Test passes with trunk and 1.4


Thanks,

David




More information about the asterisk-dev mailing list